New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openafs_1_8: Include support for Linux 4.20 #56080
Conversation
OpenAFS version 1.8.2 does not have support for Linux 4.20, meaning that linuxPackages_latest.openafs_1_8 would fail to build. This patch adds patches taken from the OpenAFS git to remove the references to deprecated functions. This has been tested on Linux 4.20 and Linux 4.14 This patch must be removed when OpenAFS 1.8.3 is released and improved when Linux 5.0 is added to Nix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(Compiles on my computer, can not test on production though.)
I haven't tested the server (I don't have a machine setup for that, and don't feel like making a new Kerberos realm), but I'm successfully logged into several cells and able to interact with files |
Should I change base to staging or is master fine for <100 rebuilds? |
@artemist master is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client works
cc @spacefrogg |
So this only provides a fix for 1.8. The default is 1.6 and it will probably need fixing or the default will need to be bumped. |
@artemist Thank you! |
@artemist Would you consider patching version 1.6 also? Or provide me with guidance on how to acquire the patch for the 1.6 branch? Testing the server is not necessary. The kernel module solely affects the client. |
@spacefrogg I've never used OpenAFS 1.6. There are some patches on the git server, but those are for 1.8, and I don't know how well they'll apply to 1.6. You can just try to apply these patches though. |
Motivation for this change
OpenAFS version 1.8.2 does not have support for Linux 4.20,
meaning that linuxPackages_latest.openafs_1_8 would fail
to build.
Things done
This patch adds patches taken from the OpenAFS git (via the Arch AUR) to
remove the references to deprecated functions. This has been
tested on Linux 4.20 and Linux 4.14
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)