Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slic3r-prusa3d: 1.41.2 -> 1.41.3 #56006

Merged
merged 1 commit into from Feb 18, 2019
Merged

Conversation

mweinelt
Copy link
Member

Motivation for this change

Upstream version bump.

https://github.com/prusa3d/Slic3r/releases/tag/version_1.41.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Adds support for the following new printer variants:
- Original Prusa i3 MK3S
- Original Prusa i3 MK3S MMU2S
- Original Prusa i3 MK2.5S
- Original Prusa i3 MK2.5S MMU2S
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works for me ;)

@mweinelt
Copy link
Member Author

+1 works for me ;)

Did you actually do a test print while I was in the kitchen?!

@Moredread
Copy link
Contributor

Duplicate of #55641 :p

It seems though that the sha256 had changed in the meantime, yours is correct. I'll close my PR.

@andir
Copy link
Member

andir commented Feb 18, 2019 via email

@mweinelt
Copy link
Member Author

Duplicate of #55641 :p

It seems though that the sha256 had changed in the meantime, yours is correct. I'll close my PR.

My bad, I didn't search before opening the pull request.

@Moredread
Copy link
Contributor

@mweinelt @andir I normally try to keep the package up-to-date as soon as a release is posted. Can I cc you in the future, so we can avoid duplicate work?

I already have done a bit of work for the current development version in #55475

Maybe you want to have a look, when it finally is released.

@Moredread
Copy link
Contributor

@andir I think they only do this shortly after a release. If it happens again we might want to do this though.

@Moredread
Copy link
Contributor

@mweinelt No problem :)

@mweinelt
Copy link
Member Author

@mweinelt @andir I normally try to keep the package up-to-date as soon as a release is posted. Can I cc you in the future, so we can avoid duplicate work?

Not sure if I'll be a regular contributor, this is my first pull request to nixpkgs. You can certainly highlight me to give your changes a try though.

@Moredread
Copy link
Contributor

@GrahamcOfBorg build slic3r-prusa3d

@Moredread
Copy link
Contributor

cc @thorstenweber83

@Moredread Moredread mentioned this pull request Feb 18, 2019
10 tasks
@andir
Copy link
Member

andir commented Feb 18, 2019

Printed succesfully!

print

@andir andir merged commit f7c6e6b into NixOS:master Feb 18, 2019
@mweinelt
Copy link
Member Author

Great, next time don't print it with the side up and it won't look like 💩!

@Moredread
Copy link
Contributor

@andir just out of interest what is that part for?

@mweinelt
Copy link
Member Author

mweinelt commented Feb 18, 2019 via email

@mweinelt
Copy link
Member Author

(Because the email reply stripped the image as it does not support markdown)

Whiteboard Marker Holder

@Moredread
Copy link
Contributor

Nice :) Has it been posted online somewhere?

@mweinelt
Copy link
Member Author

Design by @fooker, maybe he still has the design files lying around.

@fooker
Copy link
Contributor

fooker commented Feb 25, 2019

@Moredread: here you go: https://www.thingiverse.com/thing:3438498

@Moredread
Copy link
Contributor

Thanks :) @mweinelt already sent me the file privately. I printed it and it looks fantastic!

@mweinelt mweinelt deleted the slic3r-prusa3d/1.41.3 branch February 24, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants