New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slic3r-prusa3d: 1.41.2 -> 1.41.3 #56006
Conversation
Adds support for the following new printer variants: - Original Prusa i3 MK3S - Original Prusa i3 MK3S MMU2S - Original Prusa i3 MK2.5S - Original Prusa i3 MK2.5S MMU2S
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 works for me ;)
Did you actually do a test print while I was in the kitchen?! |
Duplicate of #55641 :p It seems though that the sha256 had changed in the meantime, yours is correct. I'll close my PR. |
If they have the habit of changing tags/releases shouldn't we pin it to the
commit then?
…On Mon, 18 Feb 2019, 21:03 André-Patrick Bubel, ***@***.***> wrote:
Duplicate of #55641 <#55641> :p
It seems though that the sha256 had changed in the meantime, yours is
correct. I'll close my PR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#56006 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAm_dA5ul1tSOkqQ8X0zgDIad1huSaGGks5vOwcSgaJpZM4bBcym>
.
|
My bad, I didn't search before opening the pull request. |
@andir I think they only do this shortly after a release. If it happens again we might want to do this though. |
@mweinelt No problem :) |
Not sure if I'll be a regular contributor, this is my first pull request to nixpkgs. You can certainly highlight me to give your changes a try though. |
@GrahamcOfBorg build slic3r-prusa3d |
Great, next time don't print it with the side up and it won't look like 💩! |
@andir just out of interest what is that part for? |
It's a miniature of the white board marker holder at our local hackerspace.
…On 2/18/19 11:10 PM, André-Patrick Bubel wrote:
@andir <https://github.com/andir> just out of interest what is that part
for?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56006 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AAICD0V4TeHBpiKty3GipAbhZXnUs7qiks5vOyTNgaJpZM4bBcym>.
|
Nice :) Has it been posted online somewhere? |
Design by @fooker, maybe he still has the design files lying around. |
@Moredread: here you go: https://www.thingiverse.com/thing:3438498 |
Thanks :) @mweinelt already sent me the file privately. I printed it and it looks fantastic! |
Motivation for this change
Upstream version bump.
https://github.com/prusa3d/Slic3r/releases/tag/version_1.41.3
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)