Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-nix-serve: Add some hint on howto get valid signing keys. #56004

Merged
merged 1 commit into from Feb 21, 2019

Conversation

eskimor
Copy link
Contributor

@eskimor eskimor commented Feb 18, 2019

Motivation for this change

Usually enabling features on nixos is pretty easy, for nix-serve it was unnecessary hard as I had to find some stack overflow answer to figure out howto create signing keys.

Things done

Nothing - only doc fix.

@@ -31,6 +31,9 @@ in
default = null;
description = ''
The path to the file used for signing derivation data.
Generate with: nix-store --generate-binary-cache-key cache.example.com-1 nix-serve.sec nix-serve.pub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the same example as in the Nix and nix-store manuals for consistency? Perhaps even refer to the man page as well.

nix-store --generate-binary-cache-key key-name secret-key-file public-key-file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sarah! :-) Thanks for the review - fixed! - I am not sure what format stuff is supported in the description, but from reading other options I figured basic markdown should be available?

@eskimor eskimor changed the title Add some hint on howto get valid signing keys. nixos-nix-serve: Add some hint on howto get valid signing keys. Feb 21, 2019
@Mic92 Mic92 merged commit 183919a into NixOS:master Feb 21, 2019
@eskimor eskimor deleted the add-nix-serve-help branch February 21, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants