Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "libcxx: add linker scripts for libc++.a to ensure libc++abi.a… #56030

Merged
merged 1 commit into from Feb 19, 2019
Merged

Revert "libcxx: add linker scripts for libc++.a to ensure libc++abi.a… #56030

merged 1 commit into from Feb 19, 2019

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Feb 19, 2019 •
edited

… is properly linked"

This reverts commit 72e1764.

This causes the GHC panic reported in issue #55848. Discussion on what's going on is available in that issue. This may not be needed if we can figure out how to patch GHC to avoid the panic.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Revert "libcxx: add linker scripts for libc++.a to ensure libc++abi.a…
8cb7ea7 
… is properly linked"

This reverts commit 72e1764.

This causes the GHC panic reported in issue NixOS#55848.
@matthewbauer
Copy link
Member Author

Merging for now to get this in by 19.03. I definitely think we should try to get a better fix eventually by either patching GHC or some other way.

@matthewbauer matthewbauer merged commit 5d0b0bb into NixOS:staging Feb 19, 2019
@matthewbauer matthewbauer mentioned this pull request Feb 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewbauer @GrahamcOfBorg