Skip to content
This repository has been archived by the owner on Aug 6, 2020. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/systemd
base: 837d559dfabe
Choose a base ref
...
head repository: NixOS/systemd
compare: 6bcb84439cc7
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on Feb 19, 2019

  1. Refuse dbus message paths longer than BUS_PATH_SIZE_MAX limit.

    Even though the dbus specification does not enforce any length limit on the
    path of a dbus message, having to analyze too long strings in PID1 may be
    time-consuming and it may have security impacts.
    
    In any case, the limit is set so high that real-life applications should not
    have a problem with it.
    
    (cherry picked from commit 61397a6)
    Riccardo Schirone authored and fpletz committed Feb 19, 2019
    Copy the full SHA
    3fc8aaf View commit details
    Browse the repository at this point in the history
  2. Allocate temporary strings to hold dbus paths on the heap

    Paths are limited to BUS_PATH_SIZE_MAX but the maximum size is anyway too big
    to be allocated on the stack, so let's switch to the heap where there is a
    clear way to understand if the allocation fails.
    
    (cherry picked from commit f519a19)
    Riccardo Schirone authored and fpletz committed Feb 19, 2019
    Copy the full SHA
    77399c2 View commit details
    Browse the repository at this point in the history
  3. sd-bus: if we receive an invalid dbus message, ignore and proceeed

    dbus-daemon might have a slightly different idea of what a valid msg is
    than us (for example regarding valid msg and field sizes). Let's hence
    try to proceed if we can and thus drop messages rather than fail the
    connection if we fail to validate a message.
    
    Hopefully the differences in what is considered valid are not visible
    for real-life usecases, but are specific to exploit attempts only.
    
    (cherry picked from commit 6d586a1)
    poettering authored and fpletz committed Feb 19, 2019
    Copy the full SHA
    6bcb844 View commit details
    Browse the repository at this point in the history