Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: avoid xorg build dependency #56066

Closed
wants to merge 1 commit into from
Closed

emacs: avoid xorg build dependency #56066

wants to merge 1 commit into from

Conversation

jacereda
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Feb 25, 2019

I'm afraid I fail to see the benefit of this. lndir is only 21kB and depends on nothing execept glibc.
Due to lazy eval, xorg isn't pulled in by lndir.
Current code (with lndir) is much shorter and easier to read.

@jacereda
Copy link
Contributor Author

I have xorgproto.meta.broken=true on my Mac because it helps me detect packages that probably need a x11Support flag. lndir includes a bunch of xorgproto headers (go figure why).

Would it be better to have lndir be one of the forks that doesn't require xorgproto headers to build?

@Mic92
Copy link
Member

Mic92 commented Feb 27, 2019

They seems to pull something like three macros from x11, which could be inlined
instead of depending on the headers: https://github.com/freedesktop/lndir/blob/master/lndir.c#L75

@xeji
Copy link
Contributor

xeji commented Feb 27, 2019

Yes, freeing lndir of these minimal x11 build deps would be a great thing. Definitely nicer than replacing each occurence of lndir in nixpkgs with a bunch of bash code.

@jacereda jacereda mentioned this pull request Feb 28, 2019
Merged
@vcunat
Copy link
Member

vcunat commented Mar 1, 2019

Replaced.

@vcunat vcunat closed this Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jacereda @xeji @Mic92 @vcunat @GrahamcOfBorg