libgdiplus: avoid unnecessary/dangerous flags

Fixes https://trac.macports.org/ticket/24501 See mono/libgdiplus#534
macports · Feb 20, 2019 · b85b6a4 · b85b6a4
1 parent 4fd00ff
commit b85b6a4
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/devel/libgdiplus/Portfile b/devel/libgdiplus/Portfile
@@ -4,7 +4,7 @@ PortSystem              1.0
 
 name                    libgdiplus
 version                 2.10.9
-revision                7
+revision                8
 categories              devel
 platforms               darwin
 maintainers             {mcalhoun @MarcusCalhoun-Lopez} openmaintainer
@@ -36,7 +36,8 @@ depends_lib             port:jpeg \
 patchfiles              patch-freetype-2.5.1.diff \
                         patch-libpng-1.5.diff \
                         yosemite-libtool.patch \
-                        patch-no_zlib.diff
+                        patch-no_zlib.diff \
+                        patch-fix_flags.diff
 
 post-patch {
     reinplace "s/-pthread/-lpthread/g" ${worksrcpath}/configure

diff --git a/devel/libgdiplus/files/patch-fix_flags.diff b/devel/libgdiplus/files/patch-fix_flags.diff
@@ -0,0 +1,20 @@
+CFLAGS and LDFLAGS were modified for macOS in 2004.
+See https://github.com/mono/libgdiplus/commit/bce17c28c445c49e9349aace2eb0e4a9bd235aad.
+It is not entirely clear why the changes were needed because the bug report is no longer available.
+However, they are causing problems.
+See https://trac.macports.org/ticket/24501.
+
+There is an upstream pull request to fix the issue.
+See https://github.com/mono/libgdiplus/pull/534.
+--- configure.orig	2012-01-31 10:28:27.000000000 -0700
++++ configure	2019-02-20 04:30:57.000000000 -0700
+@@ -12527,9 +12527,6 @@
+ #define OSX 1
+ _ACEOF
+
+-		CFLAGS="-no-cpp-precomp $CFLAGS"
+-		LDFLAGS="-flat_namespace -undefined suppress $LDFLAGS"
+-		no_x=yes
+ 		;;
+
+ 	*)