Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and enable Bolt to support Thunderbolt 3 settings in GNOME #56046

Merged
merged 5 commits into from Feb 20, 2019
Merged

Add and enable Bolt to support Thunderbolt 3 settings in GNOME #56046

merged 5 commits into from Feb 20, 2019

Conversation

callahad
Copy link
Member

@callahad callahad commented Feb 19, 2019 •
edited

Motivation for this change

Fixes #55938

Without bolt, GNOME can't properly display its Thunderbolt settings pane, which makes it impossible to manage security levels and access control.

This is my first real nixpkgs packaging effort, feedback encouraged. (Thanks to @hedning and @jtojnar for assistance in getting this far!)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@callahad
Copy link
Member Author

Two small notes:

  • This probably needs the package (new) and module (new) labels, in addition to module (update).
  • Looks like KDE is also working on using bolt in Plasma, if anyone wants to follow that and make sure the NixOS module gets updated when appropriate.

@callahad
Copy link
Member Author

Also, I have no idea how to investigate the eval-package-list-no-aliases CI failure 😕

@vcunat
Copy link
Member

vcunat commented Feb 19, 2019

libudev is an alias for systemd. I don't expect that will change anytime soon, so you can use that directly like other packages. Using udev would work as well, as that's not implemented as an alias ATM.

@callahad
Copy link
Member Author

@vcunat: Thanks! Swapped out libudev for systemd and force-pushed the branch.

For my future self, may I ask how you figured that out it was libudev from the build failure? Or was it just preexisting knowledge?

@hedning
Copy link
Contributor

hedning commented Feb 19, 2019

Clicking on the Details link on the failed test takes you to a gist. Quoting from the failure (bolded libudev):

anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-0-gleber.ewr1.nix.ci/pkgs/os-specific/linux/bolt/default.nix:1:1 called without required argument 'libudev', at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-0-gleber.ewr1.nix.ci/lib/customisation.nix:69:12

@callahad
Copy link
Member Author

Ahhh! Thanks! Still getting good at skimming NixOS logs and separating signal from noise :)

@hedning
Copy link
Contributor

hedning commented Feb 20, 2019

Lets check that it builds on aarch too I guess.
@GrahamcOfBorg build bolt

@callahad
Copy link
Member Author

Looks like the CI is green... does anything else need to happen on my end to get this merged?

hedning
hedning approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me at least 👍

jtojnar
jtojnar approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me too

@hedning hedning merged commit bba6de6 into NixOS:master Feb 20, 2019
@callahad
Copy link
Member Author

Woo! Thank you all for your assistance in getting this in.

@callahad callahad deleted the bolt branch April 23, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@hedning hedning hedning approved these changes

@jtojnar jtojnar jtojnar approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GNOME 3 needs boltd for Thunderbolt 3 support
7 participants
@callahad @vcunat @hedning @jtojnar @worldofpeace @GrahamcOfBorg @Janik-Haag