WIP: Git config name and email #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2019 17:33
Otherwise the tests can’t find nix when run inside a pure shell.
|
Setting for each git operation ofborg does should be the way to go (see |
| @@ -76,6 +76,7 @@ let | |||
| name = "gh-event-forwarder"; | |||
| buildInputs = with pkgs; [ | |||
| bash | |||
| nix | |||
There was a problem hiding this comment.
Why does this PR need to add nix?
There was a problem hiding this comment.
See commit description of the corresponding commit: 5d73c77
|
Can be closed, fixed by e64d033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git requires an
user.nameanduser.emailto be set for most actions. ofborg shouldn’t depend on the system’s--globalsettings, instead it should provide config options.This PR is not yet doing that for
clone.rs:https://github.com/NixOS/ofborg/blob/released/ofborg/src/clone.rs#L64-L69