-
-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship pathfinders ignore the max order distance #7062
Comments
The path distance between the two docks is too far, you need to use buoys. |
It is difficult for pathfinders to be constrained by SHIP_MAX_ORDER_DISTANCE + 5, as that is a condition for consecutive orders in ManhattanDistance, not for the length of the path. I don't think it is a bug of the pathfinders. |
Likely the change that caused this could be partially reverted now that we have ship path caching. |
In fact, since we have ship path caching, it is now feasible to remove the ship order distance limit completely. |
Rescheduling to 1.10 for a proper solution, given that the PR that fixes this depends on 2 other PRs, which are not approved yet. Especially as this has been a long outstanding issue, I see no reason to rush this for 1.9. |
…when pathfinding.
OpenTTD/src/ship_cmd.cpp
Line 462 in 6b0a467
Fentwood Transport, 1954-11-03.zip
After #6784, the ship in this savegame becomes lost.
The ship becomes out of distancemanhattan reach, and the pathfinder won't be invoked.
When the ship reaches map border and comes back again, it becomes within distancemanhattan reach and re-invokes the pathfinder again, only to get out of reach again, lost.
The text was updated successfully, but these errors were encountered: