Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk3: 3.24.2 -> 3.24.3 #53960

Merged
merged 1 commit into from Jan 15, 2019
Merged

gtk3: 3.24.2 -> 3.24.3 #53960

merged 1 commit into from Jan 15, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 14, 2019

  • Drop patches, now included!
  • Fixes system tray icon madness w/awesomeWM (and others?),
    oh joyous day what a time to be alive :)
    (parent_relative fixups, been using for a while, woohoo!)
Motivation for this change
Things done

Still rebuilding against this, FWIW.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

* Drop patches, now included!
* Fixes system tray icon madness w/awesomeWM (and others?),
  oh joyous day what a time to be alive :)
  (parent_relative fixups, been using for a while, woohoo!)
@hedning
Copy link
Contributor

hedning commented Jan 15, 2019

Looks good, no new bugs reported so far: https://gitlab.gnome.org/GNOME/gtk/issues

@hedning hedning merged commit befac4a into NixOS:staging Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants