Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nzbget service: fix preStart script and add more options to module #53961

Merged
merged 1 commit into from Jan 14, 2019

Conversation

elseym
Copy link
Member

@elseym elseym commented Jan 14, 2019

Motivation for this change
  • fixes the prestart script: adds missing variable configfile
  • add options to configure datadir and firewall
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elseym elseym changed the title nzbget: fix preStart script and add more options to module nzbget service: fix preStart script and add more options to module Jan 14, 2019
@fpletz fpletz merged commit e601215 into NixOS:master Jan 14, 2019
@fpletz fpletz deleted the nzbget branch January 14, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants