Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.mbed-ls: init at 1.6.2 #53956

Closed
wants to merge 2 commits into from

Conversation

rvolosatovs
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda changed the title pythonPackages.mbed-ls: Init at 1.6.2 pythonPackages.mbed-ls: init at 1.6.2 Jan 14, 2019
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@rvolosatovs
Copy link
Member Author

@dotlambda

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.mbed-ls python3.pkgs.mbed-ls

@dotlambda
Copy link
Member

You might want to report the test failure on aarch64 to upstream.

@rvolosatovs
Copy link
Member Author

@dotlambda

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.mbed-ls python3.pkgs.mbed-ls

@dotlambda
Copy link
Member

You might want to report the test failure on aarch64 to upstream.

@rvolosatovs Did you do that? We should probably set meta.broken = stdenv.isAarch64 and add a comment with a link to the issue.

@rvolosatovs
Copy link
Member Author

@rvolosatovs rvolosatovs deleted the init/mbed-ls branch September 15, 2019 15:50
@rvolosatovs rvolosatovs mentioned this pull request Sep 16, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants