pythonPackages.fuzzywuzzy: init at 0.17.0 #53955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build python2.pkgs.fuzzywuzzy python3.pkgs.fuzzywuzzy |
dotlambda
changed the title
dotlambda
requested changes
Jan 14, 2019
| meta = with lib; { | ||
| description = "Fuzzy String Matching in Python"; | ||
| homepage = https://github.com/seatgeek/fuzzywuzzy; | ||
| license = licenses.gpl20; |
There was a problem hiding this comment.
Suggested change
| license = licenses.gpl20; | |
| license = licenses.gpl2; |
dotlambda
requested changes
Jan 14, 2019
| @@ -0,0 +1,22 @@ | |||
| { lib , buildPythonPackage , fetchPypi, pycodestyle }: | |||
There was a problem hiding this comment.
Suggested change
| { lib , buildPythonPackage , fetchPypi, pycodestyle }: | |
| { lib, buildPythonPackage, fetchPypi, pycodestyle }: |
|
This is already in #53261 |
|
@rvolosatovs Sorry that you did this without knowing there was an open pr. We get a lot of prs for python that usually bring in a lot of dependents. |
|
Happens, FWIW this was a "dependent" itself, I was working on adding a bigger package(which did not succeed at the end), so I extracted things that did work and opened a bunch of PRs today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)