Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.cypari2: fix build #53966

Merged
merged 1 commit into from Jan 14, 2019
Merged

python.pkgs.cypari2: fix build #53966

merged 1 commit into from Jan 14, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 14, 2019

Motivation for this change

Broken by a typo in f665828 causing the
sitePackages path to be wrong.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Broken by a typo in f665828 causing the
sitePackages path to be wrong.
@timokau timokau requested a review from FRidh as a code owner January 14, 2019 21:07
@timokau
Copy link
Member Author

timokau commented Jan 14, 2019

@GrahamcOfBorg build python2.pkgs.cypari2 python3.pkgs.cypari2

timokau referenced this pull request Jan 14, 2019
This changeset allows for cross-compilation of Python packages. Packages
built with buildPythonPackage are not allowed to refer to the build
machine. Executables that have shebangs will refer to the host.
@FRidh
Copy link
Member

FRidh commented Jan 14, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants