Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add textlint to nodePackages #53981

Merged
merged 1 commit into from Jan 19, 2019
Merged

Conversation

matthew-piziak
Copy link
Contributor

Motivation for this change

#53781

textlint "is an open source pluggable linting tool for natural language text".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthew-piziak
Copy link
Contributor Author

Okay this is my first contribution so it's gonna take me a bit to work through the checklist. I've never tested from a fork before so I'm going to work from this, assuming that that's the right doc.

@6AA4FD
Copy link
Contributor

6AA4FD commented Jan 15, 2019

looks good to me, though i'm new to nix as well, so i don't know if it says much. you should be aware that a merge might take a while, because a few packages got bumped up in version, so anything they depend on will probably need to be tested. good luck!

@adisbladis
Copy link
Member

Do you really need this available for all versions of nodejs?
Seems to me like the runtime version should not matter in this case.

@matthew-piziak
Copy link
Contributor Author

@adisbladis No, I definitely don't. I just thought that that was best practice. Would it be better to just provide an update for v10?

@matthew-piziak
Copy link
Contributor Author

@adisbladis I've gone and restricted this to v10.

@adisbladis
Copy link
Member

I fixed up the commit message to match https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md.

Thank you :)

@matthew-piziak
Copy link
Contributor Author

I have a continuation up here: #54443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants