Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.cryptography{,_vectors}: 2.3.1 -> 2.4.2 #53963

Merged
merged 2 commits into from Jan 18, 2019
Merged

python37Packages.cryptography{,_vectors}: 2.3.1 -> 2.4.2 #53963

merged 2 commits into from Jan 18, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
python37Packages.cryptography_vectors: 2.3.1 -> 2.4.2
178d422
@primeos
python37Packages.cryptography: 2.3.1 -> 2.4.2
a82557e 
Changelog:
https://cryptography.io/en/latest/changelog/#v2-4-2

Important changes:
- BACKWARDS INCOMPATIBLE: Dropped support for LibreSSL 2.4.x.
- Deprecated OpenSSL 1.0.1 support. OpenSSL 1.0.1 is no longer supported
  by the OpenSSL project. At this time there is no time table for
  dropping support, however we strongly encourage all users to upgrade
  or install cryptography from a wheel.
@primeos primeos requested a review from FRidh as a code owner January 14, 2019 19:20
@primeos
Copy link
Member Author

primeos commented Jan 18, 2019

This should be fine. All package tests still pass (a few are being skipped), I ran a few additional tests without any problems, and performed many Python rebuilds to check if some packages depend on version 2.3.1 or 2.3.x. I did not find any errors related to this PR during testing.

@primeos primeos merged commit 39cc1ae into NixOS:staging Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @GrahamcOfBorg