Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHCJS: Fix 8.4 and add 8.6 #53978

Merged
merged 6 commits into from Feb 1, 2019
Merged

GHCJS: Fix 8.4 and add 8.6 #53978

merged 6 commits into from Feb 1, 2019

Conversation

ElvishJerricco
Copy link
Contributor

Motivation for this change

Fixing up the GHCJS stuff. Keeping in line with the main haskellPackages being 8.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

P.S.: @peti how can I be automatically notified of GHCJS breaking in the future?

@ElvishJerricco ElvishJerricco force-pushed the ghcjs-8.4-8.6-fixes branch 2 times, most recently from 55f84eb to 5bef207 Compare January 14, 2019 23:09
@ElvishJerricco
Copy link
Contributor Author

Is this meta.maintainers = [lib.maintainers.elvishjerricco]; all I need to do for notifications when the build breaks?

@ElvishJerricco
Copy link
Contributor Author

Ping @peti

@peti
Copy link
Member

peti commented Jan 30, 2019

Yes, setting meta.maintainer will enable e-mail notifications from Hydra.

BTW, I wonder about ghcjs82. Will that build succeed after this PR?

@peti peti requested a review from basvandijk January 30, 2019 08:12
peti
peti reviewed Jan 30, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflict.

@ElvishJerricco
Copy link
Contributor Author

As for 8.2, I thought it was working but I guess not. While trying to fix it just now, I'm finding it needs several annoying overrides, including downgrading wl-pprint-text. Considering both the trouble and the fact that it seems the GHCJS community largely skipped 8.2 completely, I think we should probably just remove 8.2. Sound good, @peti?

Building 8.4 and 8.6 now. Looks like they'll finish. Once they do I'll push the fixes and this should be good to merge.

@ElvishJerricco
Copy link
Contributor Author

8.4 and 8.6 finished. I've added a commit to remove 8.2. Let me know if you'd like me to change that. Otherwise, let's merge this before we have to make merge conflicts by marking them broken again ;)

peti
peti approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Very cool, thank you for your efforts!

@ElvishJerricco
Copy link
Contributor Author

@peti can you merge this?

@peti peti merged commit 5649eb7 into NixOS:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ElvishJerricco @peti @GrahamcOfBorg