Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osquery: fix build #53967

Merged
merged 1 commit into from Jan 15, 2019
Merged

osquery: fix build #53967

merged 1 commit into from Jan 15, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 14, 2019

Motivation for this change

It seems as without the appropriate linker flag -lcrypto the
libcrypto.sh can't be found by ld which broke one of the linker
processes during compilation.

See also https://hydra.nixos.org/build/87208819

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It seems as without the appropriate linker flag `-lcrypto` the
`libcrypto.sh` can't be found by `ld` which broke one of the linker
processes during compilation.

See also https://hydra.nixos.org/build/87208819
@Ma27
Copy link
Member Author

Ma27 commented Jan 14, 2019

Please note that I'm not 100% sure why this suddenly happened. The primary goal here is to fix the package build, either way this needs more cleanup in the long term (the CMake patch diverges too much from upstream, don't know how much this contributes to the current issues though).

Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #51770 and #53001, adding flags manually should be fine 👍

@hedning hedning merged commit 380bd3b into NixOS:master Jan 15, 2019
@Ma27 Ma27 deleted the fix-osquery branch January 15, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants