virtualbox: add warning for ineffective nixpkgs config #56322
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendlas
changed the title
bendlas
added
6.topic: nixos
|
Awesome cc #56227 |
GrahamcOfBorg
added
8.has: module (update)
infinisil
requested changes
Mar 4, 2019
There was a problem hiding this comment.
There's warnings for things like that:
{
# ...
config = {
# ...
warnings = mkIf (config.nixpkgs.config.virtualbox.enableExtensionPack or false)
"'nixpkgs.virtualbox.enableExtensionPack' has no effect, please use 'virtualisation.virtualbox.host.enableExtensionPack'";
};
}
bendlas
force-pushed
the
warn-virtualbox-config
branch
from
1d21a21 to
805039d
Compare
bendlas
added
the
9.needs: port to stable
|
Oh and one more thing, by convention, the commit message should have the |
nixpkgs.config.virtualbox.enableExtensionPack doesn't do anything, but used to. Add a warning for the unsuspecting.
bendlas
force-pushed
the
warn-virtualbox-config
branch
from
805039d to
8b6a38c
Compare
infinisil
approved these changes
Mar 8, 2019
|
Cherry-picked to 19.03 in 35ee677 |
|
@infinisil this is the case for 18.09 too - shouldn't hurt to cherry-pick it there, too :-) |
|
Done in 37694c8 :) |
|
Ah yeah I made a mistake in showing the warnings code, it's a list of strings, not just a string, I didn't test this, was hoping you'd do it when changing the code. |
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nixpkgs.config.virtualbox.enableExtensionPack doesn't do anything, but
used to. Add a warning for the unsuspecting.
Motivation for this change
When testing a virtualbox update, I complained about a non-working expansion-pack, while running afoul of having it misconfigured myself (sorry for that, @ptrhlm)
Things done
Tested positive and negative.
I wonder, whether we should re-introduce the config option, though. I don't like needing os-level configuration for using the expansion pack.