Move ansible to python-modules and use toPythonApplication + ansible related packages #56323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costrouc
force-pushed
the
python-ansible-refactor
branch
from
341abc5
to
a73fffe
Compare
dotlambda
reviewed
Feb 24, 2019
dotlambda
requested changes
Feb 24, 2019
costrouc
force-pushed
the
python-ansible-refactor
branch
from
979e061
to
254dc8d
Compare
costrouc
force-pushed
the
python-ansible-refactor
branch
from
254dc8d
to
fb5f6a5
Compare
dotlambda
reviewed
Feb 27, 2019
|
@GrahamcOfBorg build python2.pkgs.ansible python3.pkgs.ansible python2.pkgs.ansible-lint python3.pkgs.ansible-lint python2.pkgs.ansible-kernel python3.pkgs.ansible-kernel |
costrouc
force-pushed
the
python-ansible-refactor
branch
from
fb5f6a5
to
abb5840
Compare
|
@GrahamcOfBorg build python2.pkgs.ansible python3.pkgs.ansible python2.pkgs.ansible-lint python3.pkgs.ansible-lint python2.pkgs.ansible-kernel python3.pkgs.ansible-kernel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Resolves #49764 by moving ansible command to python modules and setting default ansible to python3. This is necessary since several packages depend on ansible being a package. I would appreciate if this could be merged into the upcoming release. @MMesch this adds a new kernel ansible that may be useful for jupyterWith.
I would really appreciate any help with testing this PR as I do not use ansible regularly.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc: @dasJ and others already tagged in PR