Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwupd: 1.2.3 -> 1.2.8 #56390

Merged
merged 2 commits into from Jul 11, 2019
Merged

fwupd: 1.2.3 -> 1.2.8 #56390

merged 2 commits into from Jul 11, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 26, 2019

  • use C.UTF-8 instead of en_US
  • refresh sysconfdir_install patch
    • extend to vendor-directory.conf
Motivation for this change

Not sure how to link release notes reasonably,
they're in the tarballs IIRC.

Release tags:

https://github.com/hughsie/fwupd/releases/tag/1.2.5
https://github.com/hughsie/fwupd/releases/tag/1.2.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from jtojnar February 26, 2019 00:40
@dtzWill
Copy link
Member Author

dtzWill commented Feb 26, 2019

@GrahamcOfBorg test fwupd

worldofpeace
worldofpeace reviewed Feb 26, 2019
View reviewed changes
pkgs/os-specific/linux/firmware/fwupd/add-option-for-installation-sysconfdir.patch
From 44887227f7f617cbf84713ec45685cb4999039ff Mon Sep 17 00:00:00 2001
From: Jan Tojnar <jtojnar@gmail.com>
Date: Tue, 30 Oct 2018 22:26:30 +0100
Subject: [PATCH] build: Add option for installation sysconfdir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove Jan's great commit msg 🤣

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an artifact of how I regenerated it, haha, we can keep it for sure sorry :).

@dtzWill
Copy link
Member Author

dtzWill commented Mar 7, 2019

How's this looking? I think w/the fixup commit this is good?

@worldofpeace
Copy link
Contributor

Probably should run the tests, IIRC they timeout with ofborg.

@dtzWill dtzWill changed the title fwupd: 1.2.3 -> 1.2.5 fwupd: 1.2.3 -> 1.2.6 Mar 26, 2019
@worldofpeace
Copy link
Contributor

Did e3b922a but mostly with the fix-paths.patch.

The tests succeed for me locally.

Yet to look at org.freedesktop.fwupd.metainfo.xml in detail, but this really needs to be merged soon

@jtojnar
Copy link
Contributor

jtojnar commented Apr 30, 2019

Yet to look at org.freedesktop.fwupd.metainfo.xml in detail, but this really needs to be merged soon

I just scanned it quickly and found the following possible integration issues:

  • Allow the fwupdmgr tool to modify the daemon config
  • Use Plymouth when updating offline firmware

@worldofpeace
Copy link
Contributor

Use Plymouth when updating offline firmware

It appears to only call into plymouth if it's installed (g_find_program_in_path).

@mweinelt
Copy link
Member

mweinelt commented Jul 11, 2019 •
edited

This pull has become security critical for users of Logitech Unifying Devices, since fwupd before v1.2.7 has a bug, that prevents updating of the dongle.

fwupd/fwupd#1139
fwupd/fwupd@b62c3a4

A backport to NixOS 19.03 would therefore be much appreciated.

https://www.heise.de/ct/artikel/Logitech-keyboards-and-mice-vulnerable-to-extensive-cyber-attacks-4464533.html
https://www.cvedetails.com/cve/CVE-2019-13052/

@worldofpeace
Copy link
Contributor

This pull has become security critical for users of Logitech Unifying Devices, since fwupd before v1.2.7 has a bug, that prevents updating of the dongle.

hughsie/fwupd#1139
hughsie/fwupd@b62c3a4

A backport to NixOS 19.03 would therefore be much appreciated.

https://www.heise.de/ct/artikel/Logitech-keyboards-and-mice-vulnerable-to-extensive-cyber-attacks-4464533.html
https://www.cvedetails.com/cve/CVE-2019-13052/

This pull has become security critical for users of Logitech Unifying Devices, since fwupd before v1.2.7 has a bug, that prevents updating of the dongle.

hughsie/fwupd#1139
hughsie/fwupd@b62c3a4

A backport to NixOS 19.03 would therefore be much appreciated.

https://www.heise.de/ct/artikel/Logitech-keyboards-and-mice-vulnerable-to-extensive-cyber-attacks-4464533.html
https://www.cvedetails.com/cve/CVE-2019-13052/

In that case it would be good to open an issue describing this.
For the case of 19.03 we probably can't backport this pr because I'm guessing
it's backwards compatability is low.

@dtzWill @worldofpeace
fwupd: 1.2.3 -> 1.2.8
f633bf6 
* use C.UTF-8 instead of en_US
* refresh sysconfdir_install patch
  * extend to vendor-directory.conf
* update sysconfdir_install patch
* update file listing
@dtzWill @worldofpeace
fwupd: patch in paths to tools used as runtime deps
5dc9fec
@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 11, 2019 •
edited

Squished everything together.

After a brief checking I'm going to merge this as is. No point in reusing the same PR
for the next bump, It'll never get merged 🤣

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg test fwupd

@worldofpeace worldofpeace changed the title fwupd: 1.2.3 -> 1.2.6 fwupd: 1.2.3 -> 1.2.8 Jul 11, 2019
@matthewbauer matthewbauer added the 9.needs: port to stable A PR needs a backport to the stable release. label Jul 11, 2019
@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 11, 2019 •
edited

@matthewbauer I think just the one commit needs a backport?

worldofpeace
worldofpeace approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally for me. Files in filesInstalledToEtc match after inspecting a $ tree output.

@worldofpeace worldofpeace merged commit 3a25279 into NixOS:master Jul 11, 2019
@matthewbauer
Copy link
Member

Yeah probably just the version update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: package (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dtzWill @worldofpeace @jtojnar @mweinelt @matthewbauer @infinisil @GrahamcOfBorg