-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Industries: support 16 cargos in / 16 cargos out #15
Conversation
…to simple single var check
Instead of a label 'draft', you can nowedays also make a Draft Pull Request in GitHub. Just you cannot convert an existing PR to a Draft PR :D |
Is this ready for merge? |
I think @andythenorth talked about the old production cb syntax no longer working. I don't think that was fixed yet. |
I'd like to encourage you again to just replace the old production syntax by this new one and not carry a bag of backward compatible stuff around. For backward compatibility I shall make releases for some time without such change. |
I made another PR to this PR branch, removing some deprecated industry properties: PeterN#3 Apart from taking out the deprecated parts, this needs some better error reporting (if possible) of the old syntax, a migration guide, possibly better examples, and also support for 16 accepts for town houses. |
EDIT ^ OpenTTD bug, fixed by OpenTTD/OpenTTD#7364 |
FIRS branch that compiles with this and works as expected: https://github.com/andythenorth/firs/commits/v4-development-track
There are no nml docs currently. Best reference is nml examples, and https://0x0.st/zHBc.txt Newgrf wiki is up to date for the nfo spec on these changes. I favour shipping this sooner not later, nobody else is likely to test it. Best to get it in the hands of authors and fix any bugs that come up. |
Currently using peter1138's rebase.
Spec documented in the OpenTTD PR OpenTTD/OpenTTD#6867
Still WIP, known issues: