Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handbrake: 1.2.1 -> 1.2.2, rm callPackage dep #56256

Merged
merged 2 commits into from Feb 24, 2019

Conversation

Anton-Latukha
Copy link
Contributor

Motivation for this change

Update.

Also cleaned-up the direct dep on callPackage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Anton-Latukha Anton-Latukha changed the title handbrake: 1.2.1 -> 1.2.2 handbrake: 1.2.1 -> 1.2.2, rm callPackage dep Feb 23, 2019
@ryantm
Copy link
Member

ryantm commented Feb 23, 2019

@GrahamcOfBorg build handbrake

@ryantm
Copy link
Member

ryantm commented Feb 23, 2019

@GrahamcOfBorg test handbrake

@ryantm
Copy link
Member

ryantm commented Feb 23, 2019

aarch64-linux already failing on hydra trunk

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@GrahamcOfBorg test handbrake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants