Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim_customizable: Include manpages in the output #56277

Merged
merged 2 commits into from Feb 25, 2019
Merged

vim_customizable: Include manpages in the output #56277

merged 2 commits into from Feb 25, 2019

Conversation

matix2267
Copy link
Contributor

Motivation for this change

Fixes #24691.
Rebased fix from #26111, resolved conflicts, addressed review comments from that pull request.

Things done

Tested the following configurations:

  1. vim_configurable.customize { name = "vimx"; }
  2. vim_configurable.customize { wrapGui = true; wrapManual = false; name = "vim"; vimExecutableName = "vimb"; gvimExecutableName = "gvimc"; }
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Patrick Callahan and others added 2 commits February 24, 2019 04:31
@matix2267
vim-utils: include vim man pages in the output of vim_customizable.cu…
b623da7 
…stomize
@matix2267
vim: Allow independent setting of executable names
7521115 
* Allow settign gvim wrapper name independently of vim wrapper name.
* Allow setting vim wrapper name independently of derivation name.
* Refactor multiple places where name was checked for null with default
  value.
Ma27
Ma27 approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested locally with my rather legacy VIM configuration. Also tested the GUI support in a simple VM with my vimrc 👍

@Ma27 Ma27 merged commit 718de51 into NixOS:master Feb 25, 2019
@matix2267 matix2267 deleted the vim-customizable-manpages branch February 25, 2019 22:41
@xeji xeji mentioned this pull request Feb 25, 2019
Closed
7 tasks
@ncfavier
Copy link
Member

Related #164994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

installing vim_configurable.customize{...} doesn't make vim's manpage available
4 participants
@matix2267 @ncfavier @Ma27 @GrahamcOfBorg