Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesa: extract stubs #56261

Merged
merged 1 commit into from Jun 26, 2019
Merged

mesa: extract stubs #56261

merged 1 commit into from Jun 26, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Feb 23, 2019 •
edited

Motivation for this change

So that I can properly (if I'm doing it properly) override mesa_noglu.

Indirectly tested as part of #56199.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

matthewbauer
matthewbauer approved these changes Feb 23, 2019
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We also should rename mesa_noglu -> mesa as that's the more common name, but that's for another PR.

@eadwu eadwu marked this pull request as ready for review February 23, 2019 22:19
@eadwu eadwu mentioned this pull request Feb 24, 2019
Merged
10 tasks
abbradar
abbradar approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@abbradar abbradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should merge this together with #56199 to avoid several rebuilds.

@eadwu eadwu force-pushed the mesa/extract-stubs branch 2 times, most recently from 9dad5f9 to 3bf86b6 Compare June 19, 2019 00:07
@grahamc
Copy link
Member

grahamc commented Jun 26, 2019

@GrahamcOfBorg eval

@matthewbauer matthewbauer merged commit 24fea40 into NixOS:staging Jun 26, 2019
@eadwu eadwu deleted the mesa/extract-stubs branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@abbradar abbradar abbradar approved these changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eadwu @grahamc @matthewbauer @abbradar @GrahamcOfBorg