Fix #7274, Fix #7043: Town bridges store town indexes in map array. #7282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuXarick
force-pushed
the
dont-remove-bridges-when-generating-world
branch
from
de08a20
to
679175c
Compare
…ing towns with 0 population
SamuXarick
force-pushed
the
dont-remove-bridges-when-generating-world
branch
from
679175c
to
d0184df
Compare
SamuXarick
changed the title
|
You can change the assumption by adding a test at the top of GrowTownWithBridge() to ensure that no bridges are built when the population is 0. |
SamuXarick
changed the title
PeterN
reviewed
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also addresses the source of the stalls of #7274.
This patch is assuming that towns that generated with 0 population didn't build any bridges. It may not be correct. Needs better investigation.