New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perlPackages.NetServerSSPrefork: init at 0.06pre #56267
Conversation
b95c258
to
d5381ee
Compare
Please rebase onto latest master. |
Rebased on latest master and updated TestUNIXSock version to latest available (0.4) |
Would this work as well? Is the package you're using on cpan? |
I'm not sure what you mean by "work". That's a different package with different functionality. The package I'm using is on CPAN. It's here: https://metacpan.org/pod/Net::Server::SS::PreFork As I commented in my commit adding the package (which I should have pasted here):
|
ping (triage) |
Rebased onto latest master. Still think this should be fine to merge. |
Changed the version number to 0.06pre on volth's suggestion to avoid breaking the auto-updater |
Fixed the conflict with master |
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
Still important to me... This should be fine to merge, I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK in principle, but would like a few changes:
EDIT: My main concern is adding it to propagatedBuildInputs
for Starman
and the effects (if any) this might have on hydra
.
Couldn't find any direct link between Net::Server:SS::PreFork on CPAN and the GitHub repo in this PR, so did a quick review of the code differences between https://cpan.metacpan.org/authors/id/K/KA/KAZUHO/Net-Server-SS-PreFork-0.05.tar.gz and https://github.com/kazuho/p5-Net-Server-SS-PreFork/archive/5fccc0c270e25c65ef634304630af74b48807d21.zip. Looks legit to me. Diff for posterity included:
|
@GrahamcOfBorg build perlPackages.NetServerSSPrefork perldevelPackages.NetServerSSPrefork |
@GrahamcOfBorg test hydra |
@catern Can you rebase against master again? |
This package hasn't seen a release in about 9 years, and there are important features on master (namely, Unix socket support), so we'll get our version from Github.
Yes, rebased. (There were no conflicts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 56267
1
13 packages built:
- hydra-migration
- hydra-unstable
- nix-serve
- perl530Packages.CatalystXScriptServerStarman
- perl530Packages.NetServerSSPrefork
- perl530Packages.Starman
- perl530Packages.TaskPlack
- perl530Packages.TestUNIXSock
- perl532Packages.CatalystXScriptServerStarman
- perl532Packages.NetServerSSPrefork
- perl532Packages.Starman
- perl532Packages.TaskPlack
- perl532Packages.TestUNIXSock
Amazing, thank you! |
Motivation for this change
This is an optional dependency of Starman which was previously not included. If you try to use the Server::Starter compatibility of Starman, it crashes on trying to import this package.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)