Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomachine-client: 6.4.6_1 -> 6.5.6 #56269

Merged
merged 1 commit into from Feb 24, 2019
Merged

nomachine-client: 6.4.6_1 -> 6.5.6 #56269

merged 1 commit into from Feb 24, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Feb 23, 2019 •
edited

Motivation for this change

Update package. Also, since the last digit differs between the 32- and
64-bit version, remove it from the version number and introduce two
separate variables - one for each architecture.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz
nomachine-client: 6.4.6_1 -> 6.5.6
c4f4f38 
Update package. Also, since the last digit differs between the 32- and
64-bit version, remove it from the version number and introduce two
separate variables - one for each architecture.
@xeji
Copy link
Contributor

xeji commented Feb 24, 2019

Unfree package, build checked locally on x86_64-linux.

@xeji xeji merged commit fb58041 into NixOS:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talyz @xeji @GrahamcOfBorg