@aanderse something's looking weird here - did you push some on the branch than this PR?

@aanderse something's looking weird here - did you push some on the branch than this PR?

@flokli oops! pardon my git stupidity 😄

No worries! Looks better now :-)

How do you want to proceed with this? Gathering feedback from module maintainers? Running VM tests?

I'm guessing quite a few of these modules don't have tests.

In rare situations there could be implications in changing from a mkdir+chmod in the preStart script (which runs every time the service starts) to tmpfiles (which doesn't run every time the service starts, from what I read).

Given that I don't know or use many of these modules I'd say run a test when it exists as a first pass, but also ping maintainers, then we can cherry pick individual module commits one by one. Given the timeline I think that should work out.

For now I plan to hammer away at the brainless modules which are low hanging fruit, and then progressively work my way up to modules which require more thought and understanding of the program/service. That being said, if anyone wants to start pinging maintainers so individual commits can be cherry picked feel free.

Update as of 2019-04-13: Thanks to everyone for their review and feedback. The first batch of changes which have either been reviewed or have a passing NixOS test are now going to be merged into master and then removed from this PR.

Quick Summary: PermissionsStartOnly is deprecated and a module that you are listed as a maintainer for uses it. I have patched the module you maintain to not use PermissionsStartOnly anymore, but I would like a module maintainer (ie. you) to review the changes and sign off on it.

More details: #53852

Please review the list below for your name and review the changes to your module(s). I haven't ran tests yet, so if you want to run a test and confirm everything is working, that all the changes makes sense, and there won't be any problems from my changes, that would be appreciated.

If you have the ability to merge please go ahead and cherry pick the commit relevant to your module(s) if everything checks out and you're happy with the changes and then check off your module. If you do not have commit access please leave a comment stating that you accept the changes and are OK for them to be merged as is.

If there are problems with the changes it would be great if you could provide a fix, or at least explain what the issue(s) are.

Thank you for your time and effort.

Note: If a module is checked that means no further action is required (because the module has already been merged, deprecated, taken care of by someone else, etc...)

reviewed

• collectd @bjornfor @fpletz does the commit listed look good to you?
• gitea
• gollum @jgillich @primeos does the commit listed look good to you?
• lidarr @etu does the commit listed look good to you?
• liquidsoap @ehmry does the commit listed look good to you?
• memcached @coreyoconnor does the commit listed look good to you?
• mesos @cstrahan @kevincox @offlinehacker does the commit listed look good to you?
• minio @edolstra @bachp @ehmry @lethalman does the commit listed look good to you?
• mpd @Fuuzetsu @ehmry @fpletz does the commit listed look good to you?
• munge @rickynils does the commit listed look good to you?
• nexus @aespinosa @ironpinguin @Ma27 does the commit listed look good to you?
• nullmailer @sargon does the commit listed look good to you?
• nzbget
• plexpy taken care of by @bachp in the commit listed
• postgresql-backup @markuskowa does the commit listed look good to you?
• rabbitmq @Profpatsch does the commit listed look good to you?
• redmine
• rss2email @jb55 @Profpatsch does the commit listed look good to you?
• stanchion @mdaiter does the commit listed look good to you?
• syncthing @pshendry @peterhoeg @andrew-d does the commit listed look good to you?
• traefik @vdemeester does the commit listed look good to you?
• zeronet @fgaz does the commit listed look good to you?

not reviewed, but covered by tests

• clickhouse @orivej does the commit listed look good to you?
• codimd @WilliButz does the commit listed look good to you?
• couchdb @garbas does the commit listed look good to you?
• etcd @offlinehacker @ehmry @lethalman does the commit listed look good to you?
• influxdb @offlinehacker @zimbatm @ehmry @lethalman does the commit listed look good to you?
• ipfs @fpletz @ehmry @lethalman does the commit listed look good to you?
• jackett @edwtjo does the commit listed look good to you?
• mxisd @mguentner does the commit listed look good to you?
• mysql-backup
• peerflix
• radarr @edwtjo does the commit listed look good to you?
• smokeping
• sonarr @fadenb does the commit listed look good to you?
• vault @rushmorem @LnL7 @offlinehacker @pradeepchhetri does the commit listed look good to you?
• zookeeper @nathan-gs @cstrahan @pradeepchhetri does the commit listed look good to you?

not reviewed, not covered

• alerta
• apache-kafka @ragnard does the commit listed look good to you?
• aria2 @jgeerds does the commit listed look good to you?
• autossh @pSub does the commit listed look good to you?
• boinc
• charybdis @Lassulus @fpletz does the commit listed look good to you?
• confluence
• couchpotato @fadenb does the commit listed look good to you?
• crowd
• dspam @abbradar does the commit listed look good to you?
• firebird @MarcWeber does the commit listed look good to you?
• foundationdb @thoughtpolice does the commit listed look good to you?
• frab @fpletz @markuskowa this is marked as broken, should it be abandoned?
• graylog @fadenb does the commit listed look good to you?
• hbase
• heartbeat @ehmry @lethalman does the commit listed look good to you?
• hydron
• jira
• kapacitor @offlinehacker @ehmry @lethalman does the commit listed look good to you?
• minidlna
• mopidy @rickynils @fpletz does the commit listed look good to you?
• murmur @jgeerds @wkennington does the commit listed look good to you?
• nagios @thoughtpolice does the commit listed look good to you?
• netadata @lethalman does the commit listed look good to you?
• octoprint @abbradar does the commit listed look good to you?
• opendkim @abbradar does the commit listed look good to you?
• quassel @Phreedom @ttuegel does the commit listed look good to you?
• riemann-dash @rickynils does the commit listed look good to you?
• riemann-tools
• scollector @offlinehacker @ehmry @lethalman does the commit listed look good to you?
• slimserver @phile314 does the commit listed look good to you?
• squid @fpletz does the commit listed look good to you?
• teamspeak3
• unifi

module to be deprecated

• emby @fadenb does the commit listed look good to you?
• rmilter @avnik @fpletz does the commit listed look good to you?
• winstone

modules which I haven't written code for (yet?)

• acme
• aerospike
• bosun
• consul
• datadog-agent
• dkimproxy-out
• ejabberd
• elasticsearch
• errbot
• exhibitor
• firefox
• gale
• gammu-smsd
• geoip-updater
• gitlab
• graphite
• infinoted
• hydra
• lirc
• journalwatch
• kippo
• kubernetes
• mattermost
• matomo
• matrix-synapse
• meguca
• mongodb
• mwlib
• neo4j
• opentsdb
• plex
• postgresql
• postsrsd
• rethinkdb
• riak
• riak-cs
• spiped
• squeezelite
• sslh
• tarsnap
• taskserver
• tomcat
• tt-rss
• varnish
• xrdp

For syncthing, LGTM - the module doesn't appear to use any ExecStart/ExecStop/ExecReloads, so removing PermissionsStartOnly shouldn't have any effect.

@aanderse looks good!

For minio LGTM

Looks good. The tests for postgresql-backup and munge (it's the slurm test) are passing.

To move this forward, I would suggest to split this pr into smaller ones.
I would prefer to review 10 services at the time instead of 34.

@Mic92 This is split into smaller. Normally I agree that too many changes are hard to digest, but in this case I thought everything is similar so I would keep in fewer PRs with 1 commit per change unless explicitly asked. Does anyone else request more PRs to split this up?

@aanderse gollum looks fine. I tried to modify a few pages and didn't see any issues.

Looks good, and looks ilke a ton of great work. Thank you a lot! Let's let this bake on unstable a bit.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-use-home-manager-module-inside-a-declarative-container/12427/5