Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuetools: symlink cuetag to cuetag.sh #56397

Merged
merged 2 commits into from Feb 27, 2019
Merged

cuetools: symlink cuetag to cuetag.sh #56397

merged 2 commits into from Feb 27, 2019

Conversation

hhm0
Copy link
Contributor

@hhm0 hhm0 commented Feb 26, 2019

Debian-based distros call cuetag.sh "cuetag" (see https://packages.debian.org/buster/amd64/cuetools/filelist).
This adds a symlink for compatibility with those distros.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hhm0
cuetools: symlink cuetag to cuetag.sh
99d338b 
Debian-based distros call cuetag.sh "cuetag" (see https://packages.debian.org/buster/amd64/cuetools/filelist).
This adds a symlink for compatibility with those distros.
@worldofpeace
Copy link
Contributor

@hhm0 Can you squash c9c52b7 and ea13e37?
( i don't like force pushing to people branches )

@hhm0
Copy link
Contributor Author

hhm0 commented Feb 27, 2019

@worldofpeace done :-)

@worldofpeace worldofpeace merged commit 1c4630b into NixOS:master Feb 27, 2019
@hhm0
Copy link
Contributor Author

hhm0 commented Feb 27, 2019

@worldofpeace Thanks! :-)

@worldofpeace
Copy link
Contributor

@hhm0 Thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hhm0 @worldofpeace @GrahamcOfBorg