Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.tsun: init at 0.4.0 #56239

Merged
merged 1 commit into from Feb 26, 2019
Merged

nodePackages.tsun: init at 0.4.0 #56239

merged 1 commit into from Feb 26, 2019

Conversation

terlar
Copy link
Contributor

@terlar terlar commented Feb 23, 2019

Motivation for this change

Add package for tsun a TypeScript REPL:
https://github.com/HerringtonDarkholme/typescript-repl

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@terlar
Copy link
Contributor Author

terlar commented Feb 23, 2019

I wasn't sure if the practice is to also submit the generated files for the non-related versions (v6, v8). But according to the documentation it says all files:

Let me know if I should update the PR to omit those two generated files.

@infinisil infinisil merged commit b82919c into NixOS:master Feb 26, 2019
@infinisil
Copy link
Member

I think that's fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@terlar @infinisil @GrahamcOfBorg @Janik-Haag