sshd: fix startWhenNeeded and listenAddresses combination for ipv6 #56340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a continuation of #56326, @vcunat made a good comment regarding ipv6 support: #56326 (comment)
systemd.socket ListenSteam option requires ipv6 address to be enclosed
in brackets, see https://www.freedesktop.org/software/systemd/man/systemd.socket.html#ListenStream=.
In this implementation, I just check for colon in IP address string, which is not perfect but I'm not sure we need a full ipv6 regex for this purpose either.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)