Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init pythonPackages.firetv for home-assistant #56324

Merged
merged 4 commits into from Mar 2, 2019
Merged

init pythonPackages.firetv for home-assistant #56324

merged 4 commits into from Mar 2, 2019

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Feb 24, 2019

Motivation for this change

add firetv support to home-assistant

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@makefu makefu requested a review from FRidh as a code owner February 24, 2019 22:57
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.firetv python3.pkgs.firetv

@dotlambda
Copy link
Member

"python" -> "pythonPackages" in your commit messages.

@makefu
Copy link
Contributor Author

makefu commented Feb 25, 2019

@dotlambda thanks for the review!

dotlambda
dotlambda requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 0 tests in 0.000s

Please provide appropriate checkPhases or, if there are no tests, set doCheck = false and add a comment with the reason.

pkgs/development/python-modules/firetv/default.nix Outdated Show resolved Hide resolved
@makefu makefu mentioned this pull request Feb 25, 2019
Merged
dotlambda
dotlambda reviewed Feb 27, 2019
View reviewed changes
pkgs/development/python-modules/adb-homeassistant/default.nix Outdated

checkInputs = [ pytest mock ];
checkPhase = ''
py.test adb test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
py.test adb test
py.test test

adb is just the dir whose coverage they want to compute

@makefu
Copy link
Contributor Author

makefu commented Mar 2, 2019

all issues should be resolved now

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.firetv python3.pkgs.firetv

@dotlambda dotlambda merged commit 1318270 into NixOS:master Mar 2, 2019
@makefu makefu deleted the python/firetv/init branch March 2, 2019 21:13
@makefu
Copy link
Contributor Author

makefu commented Mar 2, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makefu @dotlambda @GrahamcOfBorg