сс @infinisil

Update to new variant.
cc @infinisil @Mic92 @aanderse

This change still makes me slightly nervous because it uses a simple sed command on a complex configuration syntax.

@aanderse this variant used in nginx - https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/writers/default.nix#L184-L199

whoa, can we add a bit more documentation on what is going on here and why it’s correct?

I still do not like this change. 🤷‍♂️

seems similiar to the nginx stuff (which also lacks comments ;) ) maybe @4z3 can check since he also wrote the nginx formater

Me add this script variant - https://github.com/nixcloud/nixcloud-webservices/blob/master/modules/web/webserver/lib/apache_check_config.nix#L8
Changed:

/\{/{ctx++;idx=1} -> /<[^\/]/{ctx++;idx=1}
/\}/{ctx--} -> /<\//{ctx--}

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

maybe @4z3 can check since he also wrote the nginx formater

I'm not familiar with Apache syntax, so I cannot tell whether the formatter is correct :)

Also, I haven't written the nginx formatter but only integrated 1connect/nginx-config-formatter. The awk script got introduced in #59181. That said, I do think that the awk scripts are pretty self-explanatory. Whether this simple reindenting is enough, though, is a question I don't want to answer.. :D

As for the sed script, why hasn't it been incorporated into the awk script if already going that route?

I marked this as stale due to inactivity. → More info

I marked this as stale due to inactivity. → More info

@Artturin this formatting variant will not fitt?

i dont know but the PR looked dead

Maybe someone else will be interested in PR?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1787

Rebased PR. Reopen PR not active...

can't reopen a pr which has been force pushed to, please make a new one

@Artturin ok, create new PR.