Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpdris2: 0.7 -> 0.8 #56287

Merged
merged 1 commit into from Feb 24, 2019
Merged

mpdris2: 0.7 -> 0.8 #56287

merged 1 commit into from Feb 24, 2019

Conversation

eonpatapon
Copy link
Contributor

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Feb 24, 2019

@GrahamcOfBorg build mpdris2

@xeji
Copy link
Contributor

xeji commented Feb 24, 2019

Build failure on Darwin due to dependency python-notify is unrelated to this PR, has been there since at least 2015: https://hydra.nixos.org/job/nixpkgs/trunk/mpdris2.x86_64-darwin/all?page=1

@xeji xeji merged commit 98d8bf4 into NixOS:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eonpatapon @xeji @GrahamcOfBorg