mattermost-desktop: 4.1.2 -> 4.2.0 #56289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S.: I have also added my GPG key |
worldofpeace
suggested changes
Feb 25, 2019
There was a problem hiding this comment.
Hello @jokogr
Could you please drop
phases = [ "unpackPhase" "installPhase" ];and replace it with?
dontBuild = true;
dontConfigure = true;We'd like to deprecate that.
See: #28910
Additionally, after inspecting the output I noticed that everything was
just copied to $out with no type of hierarchy.
Could you refactor the installPhase to not do that?
This can be as simple as coping everything to $out/share/mattermost-desktop
and then symlinking things from there.
|
@worldofpeace thanks for the review! I've refactored the phases to use |
pkgs/applications/networking/instant-messengers/mattermost-desktop/default.nix
Outdated
Show resolved
Hide resolved
jokogr
force-pushed
the
u/mattermost-desktop-4.2.0
branch
from
6f83cb1
to
2e9c741
Compare
|
@worldofpeace ready! |
worldofpeace
approved these changes
Feb 26, 2019
|
Thanks @jokogr 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Mattermost Desktop update was pending since November 2018.
New version seems to be using GTK 3 and has a Windows security vulnerability fixed (I guess no worries for that).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)