-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
cypress: init at 3.1.5 #56387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cypress: init at 3.1.5 #56387
Conversation
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/cypress-ui-testing-issue/2208/3 |
@acyuta108 Do you have interest in adapting the code from @erosennin as described in the discourse discussion? I think it would be great to get cypress packaged for NixOS. |
I am tempted to use https://discourse.nixos.org/t/cypress-ui-testing-issue/2208/5?u=acyuta108 from @thorstenweber83 |
@acyuta108 That sounds great. |
Rebased and upgraded to latest version of Cypress (3.2.0) Thanks for your help @thorstenweber83, @erosennin and @aanderse |
@acyuta108 I misunderstood the new solution you adopted. The solution @erosenin provided actually included the cypress binary and was reproducible. The solution you have chosen requires more work from the user and is not as reproducible as it depends on user steps and environment variables, correct? |
Both solutions install the binary and depend on the npm steps. It is the standard way to install cypress in any project/system. I'll explain why. The standard way is to These ENV options are documented by Cypress as well, which I am glad are available, otherwise we would have to inject/override somehow our binary (path). |
Ah I see. So could you use makeWrapper to make this seamless to the user? |
I'd rather not. I don't see the use and I actually foresee issues. Besides, how would you even achieve that? When you run |
I've never used cypress so I'll defer to your experience. My interest in cypress is that I'd like to start using a web testing framework inside nixos tests for web modules to provide more thorough tests. Currently most nixos tests simply ensure a web application can boot without testing functionality of the web application at all. This sounds achievable with what you've described, right? |
Absolutely. Any Nix/NixOS user can now use Cypress which is a pretty fantastic UI and end-to-end testing tool. Specs are written and javascript and run natively on a chrome browser. You can test VueJs (my fav), Reach, Angular and pretty much anything that has a UI that runs on the browser. I've been writing end-to-end specs for many years now and nothing compares to Cypress in speed, reliability and ease of use. |
Motivation for this change
Missing package.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)