Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

candle: init at 1.1 #56328

Merged
merged 2 commits into from Mar 11, 2019
Merged

candle: init at 1.1 #56328

merged 2 commits into from Mar 11, 2019

Conversation

matti-kariluoma
Copy link

Motivation for this change

I've added an application for controlling GRBL machines, its source can be found at https://github.com/Denvi/Candle

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS v18.09
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peterhoeg
peterhoeg requested changes Feb 25, 2019
View reviewed changes
pkgs/applications/misc/candle/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/misc/candle/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/candle/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/candle/default.nix Show resolved Hide resolved
@peterhoeg
Copy link
Member

@matti-kariluoma, I just realized that this is your first PR here, so I'd like to say thank you for this!

If you need anything clarified, feel free to ask.

@matti-kariluoma
Copy link
Author

I removed candle from my system, made the requested changes then reinstalled. All working!

@peterhoeg
Copy link
Member

Looks good - as the last thing, can I get you to squash the commits so we end up with one commit adding you to the maintainer list and another that has all the changes for the actual software?

@matti-kariluoma
Copy link
Author

Looks like I can't resolve the last change request, probably due to the rebase... Do I need to create a new pull request?

@matti-kariluoma
Copy link
Author

Alright, that should be all of the requsted changes. Squashed down to two commits as well

@peterhoeg peterhoeg merged commit f4ffe5c into NixOS:master Mar 11, 2019
@peterhoeg
Copy link
Member

Looks great! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@peterhoeg peterhoeg peterhoeg requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matti-kariluoma @peterhoeg @jtojnar @GrahamcOfBorg @Janik-Haag