Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btpd: init at 0.16, add module #56279

Closed
wants to merge 4 commits into from
Closed

Conversation

tadeokondrak
Copy link
Member

@tadeokondrak tadeokondrak commented Feb 24, 2019

Fixes: #75636

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

First module I've written, I probably got a few things wrong.

@tadeokondrak
Copy link
Member Author

(rebased to fix conflict)

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package seems to be missing.

nixos/modules/misc/ids.nix Outdated Show resolved Hide resolved
nixos/modules/services/torrent/btpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/torrent/btpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/torrent/btpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/torrent/btpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/torrent/btpd.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/p2p/btpd/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

Any chance for a NixOS test?

@tadeokondrak
Copy link
Member Author

Added test.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test.

nixos/modules/services/torrent/btpd.nix Show resolved Hide resolved
nixos/modules/services/torrent/btpd.nix Outdated Show resolved Hide resolved
@veprbl
Copy link
Member

veprbl commented Dec 22, 2019

I'm not entirely sure how one is supposed to use this. I set services.btpd.enable = true;, add myself to the "btpd" group.

# btcli -d /var/lib/btpd stat
cannot open connection to btpd in /var/lib/btpd (Permission denied).
# ls /var/lib/btpd -la
total 16
drwxr-xr-x  3 btpd btpd 4096 Dec 22 12:57 .
drwxr-xr-x 15 root root 4096 Dec 22 12:57 ..
-rw-r--r--  1 btpd btpd    5 Dec 22 12:57 pid
srw-------  1 btpd btpd    0 Dec 22 12:57 sock
drwxr-xr-x  2 btpd btpd 4096 Dec 22 12:57 torrents

After forcing the permissions and adding a torrent I got it to crash:

# journalctl -u btpd
-- Logs begin at Thu 2018-12-27 15:27:48 EST, end at Sun 2019-12-22 13:11:23 EST. --
Dec 22 12:57:36 nixos systemd[1]: Started BitTorrent Protocol Daemon.
Dec 22 13:10:42 nixos btpd[10772]: Dec 22 13:10:42 btpd: Starting torrent 'debian-10.2.0-i386-netinst.iso'.
Dec 22 13:10:42 nixos btpd[10772]: Dec 22 13:10:42 error: failed to stat '/home/user/debian-10.2.0-i386-netinst.iso' (Permission denied).
Dec 22 13:10:42 nixos btpd[10772]: Dec 22 13:10:42 btpd: Stopped torrent 'debian-10.2.0-i386-netinst.iso'.
Dec 22 13:10:42 nixos systemd[1]: btpd.service: Main process exited, code=dumped, status=11/SEGV
Dec 22 13:10:42 nixos systemd[1]: btpd.service: Failed with result 'core-dump'.

@veprbl
Copy link
Member

veprbl commented Dec 22, 2019

This may become abandonware: btpd/btpd#47

@stale
Copy link

stale bot commented Jun 19, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2020
@Ekleog
Copy link
Member

Ekleog commented Sep 13, 2020

Btpd appears to have been taken over, but I'm not sure there are still people interested in this?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 13, 2020
@veprbl
Copy link
Member

veprbl commented May 9, 2021

@GrahamcOfBorg eval
@GrahamcOfBorg build btpd
@GrahamcOfBorg test btpd

@stale
Copy link

stale bot commented Apr 19, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 19, 2022
@sikmir
Copy link
Member

sikmir commented May 21, 2022

Still nice to have.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 21, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 8, 2023
@AndersonTorres
Copy link
Member

Closing as dead. Anyone feel free to restart!

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request] btpd
10 participants