Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acpilight: init at 1.1 #56220

Merged
merged 1 commit into from Feb 24, 2019
Merged

acpilight: init at 1.1 #56220

merged 1 commit into from Feb 24, 2019

Conversation

SeTSeR
Copy link
Contributor

@SeTSeR SeTSeR commented Feb 22, 2019

Motivation for this change

This adds acpilight, a backward-compatible replacement for xbacklight, that uses ACPI interface instead of XRandR

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor

etu commented Feb 22, 2019

@GrahamcOfBorg build acpilight

@etu
Copy link
Contributor

etu commented Feb 22, 2019

@GrahamcOfBorg eval

@etu
Copy link
Contributor

etu commented Feb 23, 2019

@SeTSeR Care to squash your commits to one or should I do it while merging?

@SeTSeR
acpilight: init at 1.1
4cae259 
Use pname instead of manual adding version to package name
@SeTSeR
Copy link
Contributor Author

SeTSeR commented Feb 23, 2019

@etu I'll take care about it

@etu etu merged commit d4f487a into NixOS:master Feb 24, 2019
@etu
Copy link
Contributor

etu commented Feb 24, 2019

@SeTSeR Perfect, thanks! 👍

@rasendubi
Copy link
Member

./hardware/acpilight.nix is missing in modules-list.nix

Added it: #57920

dotlambda
dotlambda reviewed Apr 1, 2019
View reviewed changes
pkgs/misc/acpilight/default.nix
homepage = "https://gitlab.com/wavexx/acpilight";
description = "ACPI backlight control";
license = licenses.gpl3;
maintainers = with maintainers; [ "smakarov" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be without quotes?

@dotlambda dotlambda mentioned this pull request Apr 1, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu left review comments

@dotlambda dotlambda dotlambda left review comments

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SeTSeR @etu @rasendubi @dotlambda @GrahamcOfBorg @Janik-Haag