Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mautrix-whatsapp: 2019-02-11 -> 2019-02-24 #56344

Merged
merged 2 commits into from Mar 30, 2019
Merged

mautrix-whatsapp: 2019-02-11 -> 2019-02-24 #56344

merged 2 commits into from Mar 30, 2019

Conversation

Vskilet
Copy link
Contributor

@Vskilet Vskilet commented Feb 25, 2019

Motivation for this change

The previous versions have a problem when it run for a long time. This works well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Vskilet Vskilet changed the title Mautrix whatsapp mautrix-whatsapp: 2019-02-11 -> 2019-02-24 Feb 25, 2019
@Ma27
Copy link
Member

Ma27 commented Mar 30, 2019

The change itself seems fine. I'll do some testing with it later that evening :)

@Ma27
Copy link
Member

Ma27 commented Mar 30, 2019

@GrahamcOfBorg build mautrix-whatsapp

@Ma27 Ma27 merged commit e24e3cc into NixOS:master Mar 30, 2019
@Ma27
Copy link
Member

Ma27 commented Mar 30, 2019

@Vskilet thanks!

@Ma27
Copy link
Member

Ma27 commented Mar 30, 2019

Backported as d685800, 2831fd0 as I experienced similar issues on my setup as well.

@Vskilet Vskilet deleted the mautrix-whatsapp branch April 8, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vskilet @Ma27 @GrahamcOfBorg