Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certmgr: 1.6.1 -> 1.6.4 #56356

Merged
merged 1 commit into from Feb 25, 2019
Merged

certmgr: 1.6.1 -> 1.6.4 #56356

merged 1 commit into from Feb 25, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Feb 25, 2019

Motivation for this change

@GrahamcOfBorg build certmgr certmgr-selfsigned
@GrahamcOfBorg test certmgr

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Feb 25, 2019

@GrahamcOfBorg test certmgr.command certmgr.systemd

@srhb
Copy link
Contributor

srhb commented Feb 25, 2019

Not sure why OfBorg isn't willing to build the linux test. Queue looks fine. I've ran it both with the regular package and certmgr-selfsigned, just in case -- everything checks out.

@srhb srhb merged commit fe2a2b3 into NixOS:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants