Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] backport pythonPackages: trezor: 0.10.2 -> 0.11.1 #56307

Closed
wants to merge 1 commit into from
Closed

[18.09] backport pythonPackages: trezor: 0.10.2 -> 0.11.1 #56307

wants to merge 1 commit into from

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Feb 24, 2019

(cherry picked from commit bdb81a8)

Motivation for this change

Backport for 18.09 as stated in the original PR

  1. we add a lot of features into Trezor and these are not accessible if a user has an older version of python-trezor leading to frustration

  2. I assume NixPkgs Electrum maintainers don't backport security patches individually, but rather the whole package is being updated to the newest stable release. This release might already be depending on the new python-trezor package, using the new API, etc. so it makes sense to upgrade the whole package for python-trezor too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@1000101 1000101 requested a review from FRidh as a code owner February 24, 2019 17:43
@1000101 1000101 closed this Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants