Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] wget: 1.19.5 -> 1.20.1 #56375

Merged
merged 2 commits into from Feb 27, 2019
Merged

[18.09] wget: 1.19.5 -> 1.20.1 #56375

merged 2 commits into from Feb 27, 2019

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Feb 25, 2019 •
edited

Motivation for this change

fixes #56372

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji xeji changed the title wget: 1.19.5 -> 1.20.1 [18.09] wget: 1.19.5 -> 1.20.1 Feb 25, 2019
@vcunat
Copy link
Member

vcunat commented Feb 25, 2019

Hmm, I see the original approach wasn't finished/merged: #52979

@tokudan
Copy link
Contributor Author

tokudan commented Feb 25, 2019

@vcunat Looks like it's quite complicated to backport the change to the old version.
Considering the changes in wget between 1.19.5 to 1.20.1 I don't think it's really worth it and just moving to the new version is probably a lot easier: http://git.savannah.gnu.org/cgit/wget.git/tree/NEWS

vcunat
vcunat approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS really do seem "safe".

@vcunat vcunat merged commit 022a6f7 into NixOS:release-18.09 Feb 27, 2019
vcunat added a commit that referenced this pull request Feb 27, 2019
@vcunat
Merge #56375: wget: 1.19.5 -> 1.20.1 (into release-18.09)
2fa7fc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tokudan @vcunat @GrahamcOfBorg @dtzWill @delroth