Support parameters in S3 URLs #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which splits a URL into localtor and parameter parts
edolstra
reviewed
Feb 26, 2019
|
Looks good to me! |
pradd
force-pushed
the
support_s3_region_param
branch
from
ac200c3
to
25573c1
Compare
pradd
force-pushed
the
support_s3_region_param
branch
from
25573c1
to
06d6335
Compare
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds proper support for S3 URL parameters.
Currently, an attempt to download artifacts with fetchTarball or fetchUrl fails for buckets residing in regions other than us-east-1. Nix manual states explicitly that, when using another region, the "region"
parameter should be passed. Which doesn't work since us-east-1 is hardcoded.