New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix thumbnails generation in nautilus #56188
Conversation
Instead of |
This would add a dependency from nautilus to all the potential thumbnailers. I quite like the flexibility in here. But
|
Ah, OK. If I understand it right, the best approach might be to build this tiny tool separately make it depend on the set of thumbnailers, but that would probably be too complex and I don't see a significant issue in |
Now, given that the sandbox aims to protect about programs writing in strange locations when they only need to write one output file (like nix sandboxes), it does not hurt to provide access to the whole /run/current-system as it is a symlink to the store and the whole store is already mounted. |
Yes, if that's the (main) purpose of this sandbox. I just thought you also need the thumbnailers to reside in the sandbox, and you won't have them there (in |
We might want to do the same in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible to me at least (as @jtojnar says we should do the same for gnome-desktop).
Ah, sorry, should've mentioned that we just merged an update to |
1ee5056
to
a3e440c
Compare
@hedning This was a mess, so I rebased my changes. |
Cheers, I'll merge after ofborg is done so we'll get this into 19.03 |
@GrahamcOfBorg build gnome3.nautilus gnome3.gnome-desktop |
Tested nautilus and it produces pdf thumbnails. Couldn't get gnome-documents to work, but I think that's an issue with the gnome-desktop version bump (eog also fails to produce thumbnails on master now), I'll look into it. |
thanks ! |
Thanks for tracking down and fixing the issue :) Solved the gnome-desktop problem in #56346 |
Motivation for this change
PDF thumbnails (and possibly others) are not generated in nautilus
because the thumbnailers execution is sandboxed.
/run/current-system
is not mounted in the sandbox, and system binariesthat rely on
$PATH
are not resolvable.It turns out that .desktop files sometimes contain an absolute path, but
I think it better to just mount /run/current-system in the sandbox
rather than enforcing all the .desktop files to contain an absolute
path, especially since some (like firefox) break when an absolute path
is used there.
Things done