Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squeezelite: fix 'cfg' reference (fixes eval!) #56271

Merged
merged 1 commit into from Feb 24, 2019
Merged

squeezelite: fix 'cfg' reference (fixes eval!) #56271

merged 1 commit into from Feb 24, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 24, 2019

Motivation for this change

Eval was broken :(

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 24, 2019

lol borg "fails" this because of the problem this fixes!

@dtzWill dtzWill merged commit b5c0aa9 into NixOS:master Feb 24, 2019
@dtzWill dtzWill deleted the fix/squeeze branch February 24, 2019 00:28
@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

Sorry, and thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @ryantm