-
-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AI and GS to framerate window #7178
Conversation
|
As these happen in the game loop, and do affect the game loop total monitor, would it be possible to have these within sub-grouping of "scripts" in there, rather than appended to the end? |
That's going to be really annoying :P Since the AIs are handled specially right now, with regard to strings. |
I think we're not meant to use snprintf: src/safeguards.h:#define snprintf SAFEGUARD_DO_NOT_USE_THIS_METHOD I think seprintf() is our preferred call, this takes lastof() rather than lengthof() |
Should probably add safeguards.h in the relevant file. Played around with it a bit, one suggestion - "AI n - {AI_NAME}" with the inclusion of the dash? I don't think the window is long enough that it's worth bothering about making it scroll |
Would it be worth grouping all the AI/GS together with a "grand total" and having all the individual scripts nested underneath it? |
d0d8428
to
7f491a4
Compare
7f491a4
to
d7dfb6e
Compare
I think this is everything. The scripts total is a bit weird, since AIs not running every tick contribute less to the average, so the total can appear to be less than the simple sum. |
Is this intended to be a squash or do you want to rebase/squash commits yourself? |
This was initially intended to be a squash, but maybe it's worthwhile to separate commits for the AI/GS measurements and the resize/scroll behaviour? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking to open a graph does not work properly with the scrolling; you need to use this->vscroll->GetScrolledRowFromWidget()
instead of this->GetRowFromWidget()
. Most windows have a local variable this->vscroll
which is assigned in the constructor.
0dfb543
to
9f18a7c
Compare
Squashed to two logical commits, should be ready for merge now. |
This can make the framerate window extremely tall, and it should maybe be made scrolling.