Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News font size is bugged if font size was changed for a multiple times #7266

Closed
Nik-mmzd opened this issue Feb 23, 2019 · 7 comments
Closed

News font size is bugged if font size was changed for a multiple times #7266

Nik-mmzd opened this issue Feb 23, 2019 · 7 comments
Labels
component: interface This is an interface issue regression It used to work, and now it's broken.
Milestone
1.9.0

Comments

@Nik-mmzd
Copy link

Version of OpenTTD

Compiled from source, commit 00d28a5

Expected result

News with "Normal size" font

Actual result

News still using "Quad size" font instead of "Normal size"

Steps to reproduce

Settings => Font Size
Set it to "Quad Size" and then back to "Normal Size"
News will be in "Quad Size" font instead of "Normal"
image
@nielsmh
Copy link
Contributor

nielsmh commented Feb 23, 2019

I can reproduce this. It probably requires using vector fonts to trigger, not sure.
#7003 is the PR introducing this bug.

@nielsmh nielsmh added component: interface This is an interface issue regression It used to work, and now it's broken. labels Feb 23, 2019
@nielsmh nielsmh added this to the 1.9.0 milestone Feb 23, 2019
@Nik-mmzd
Copy link
Author

If needed:
I'm using Hack monotype font

small_font = Hack, Bold
medium_font = Hack, Bold
large_font = Hack, Bold
mono_font = Hack

@nielsmh
Copy link
Contributor

nielsmh commented Feb 23, 2019

According to @LordAro the bug manifests differently if using bitmap fonts, then the news window is just offset on screen.

This bug probably isn't critical, it doesn't affect game logic, and can be worked around by a save, quit, reload cycle.

@LordAro
Copy link
Member

LordAro commented Feb 23, 2019

@PeterN
Copy link
Member

PeterN commented Feb 23, 2019

I can't reproduce this, is it perhaps something that only occurs on Windows?

@Nik-mmzd
Copy link
Author

@PeterN I'm using Linux 🤷‍♂️
And set up custom font using openttd.cfg

@PeterN
Copy link
Member

PeterN commented Feb 23, 2019

I'm on Linux, and have set up the same fonts, and cannot reproduce. Hmm.

PeterN added a commit to PeterN/OpenTTD that referenced this issue Feb 24, 2019
@PeterN
Fix OpenTTD#7266: Reorder reinitialization of caches when changing fo…
af87a33 
…nt zoom level.
PeterN added a commit to PeterN/OpenTTD that referenced this issue Feb 24, 2019
@PeterN
Fix OpenTTD#7266: Reorder reinitialization of caches when changing fo…
cae9d22 
…nt zoom level.
@PeterN PeterN closed this as completed in 195fd0d Feb 24, 2019
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
@PeterN @nielsmh
Fix OpenTTD#7266: Reorder reinitialization of caches when changing fo…
f00417f 
…nt zoom level. (OpenTTD#7273)
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@PeterN @douiwby
Fix OpenTTD#7266: Reorder reinitialization of caches when changing fo…
588193e 
…nt zoom level. (OpenTTD#7273)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue regression It used to work, and now it's broken.
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
4 participants
@PeterN @nielsmh @LordAro @Nik-mmzd